serial.Classes.Simple2 Questions

[dsmes]

Should even simple functions be added as a method? e.g. I have a function that calculates the modified Julian day that doesn't need to be passed any data. But should I pass it the data table anyway so it can write the result there?

MJD = function(self, data)
   local tm = {}
   tm = os.date('*t')
   self.MJD = 367 * tm.year - math.floor(7 * (tm.year + math.floor((tm.month + 9) / 12)) / 4)
         + math.floor(275 * tm.month / 9) + tm.day + 1721013.5 - 2400000.5
end,

BTW, glad someone remembers punched cards (our kids will think Lua is just as primative). Were you ever exposed to teletype "ticker-tape"?

[Rob H]

I'd probably not put that in the class - it's more of a utility function and should just return the result. Either make it a local function in the same file (before the class definition), or put it in a separate file and use require to load that file.

I used to own a Friden Flexowriter back in the late 70s

[dsmes]

Why "before the class definition"? I know a function has to be defined before it's called, but doesn't that happen at G startup before any serial data is received?

[Rob H]

Because I suggested making it a local function ie

local function MJD()

That way you avoid polluting the global namespace. But for anything declared as local it must be defined before it is used because of the Lua scoping rules.