PDA

View Full Version : minor glitch in SunRiseSet.lua + copyright question



Tieske8
January 3rd, 2008, 08:24 AM
Hi,

The girder\luascript\sunriseset.lua script contains a couple of global variables that should have been local;

Line 181 + 269 -> H should have been defined local
Line 187 + 274 -> T should have been defined local

Copyright question; this sunriseset-script only works with the PRO version of girder because it uses the scheduler library.
I modified it to not use the scheduler, and hence run on the standard version of girder. To do this I used several functions from this script, it doesn't mention any copyrights, just an external link for the algorythm.

I could upload the scheduler independent script, but wish to do so only if it is allowed......

Ron
January 3rd, 2008, 10:44 AM
While we very much appreciate and encourage playing with the various Lua files to make a Girder an even better product in this case I would ask you not upload that work as it is a adding functionality that was intended for a more expensive version.

Thanks for the bug fixes!!

Ron
January 3rd, 2008, 10:46 AM
Looks like my local copy has already defined them as local. What version are you running?

Tieske8
January 3rd, 2008, 10:57 AM
version 4.0.15, standard. Timestamp lua file: 28-Jul-2006, 14:00

LINES 187-196

--7b. finish calculating H and convert into hours
--if rising time is desired:
H = 360 - math.deg (math.acos(cosH))

H = H / 15


--8. calculate local mean time of rising/setting
T = H + RA - (0.06571 * t) - 6.622
if T < 0 then

Ron
January 3rd, 2008, 11:11 AM
Oh 4.0 :-) Yes,.. that one is getting older by now. Check your email :-)