Results 1 to 5 of 5

Thread: minor glitch in SunRiseSet.lua + copyright question

  1. #1
    Join Date
    Jul 2007
    Location
    Netherlands
    Posts
    370

    Default minor glitch in SunRiseSet.lua + copyright question

    Hi,

    The girder\luascript\sunriseset.lua script contains a couple of global variables that should have been local;

    Line 181 + 269 -> H should have been defined local
    Line 187 + 274 -> T should have been defined local

    Copyright question; this sunriseset-script only works with the PRO version of girder because it uses the scheduler library.
    I modified it to not use the scheduler, and hence run on the standard version of girder. To do this I used several functions from this script, it doesn't mention any copyrights, just an external link for the algorythm.

    I could upload the scheduler independent script, but wish to do so only if it is allowed......

  2. #2
    Join Date
    Jan 1998
    Location
    Jupiter, FL
    Posts
    13,550

    Default

    While we very much appreciate and encourage playing with the various Lua files to make a Girder an even better product in this case I would ask you not upload that work as it is a adding functionality that was intended for a more expensive version.

    Thanks for the bug fixes!!
    Ron
    No support through PM

  3. #3
    Join Date
    Jan 1998
    Location
    Jupiter, FL
    Posts
    13,550

    Default

    Looks like my local copy has already defined them as local. What version are you running?
    Ron
    No support through PM

  4. #4
    Join Date
    Jul 2007
    Location
    Netherlands
    Posts
    370

    Default

    version 4.0.15, standard. Timestamp lua file: 28-Jul-2006, 14:00

    LINES 187-196
    Code:
            --7b. finish calculating H and convert into hours
            --if rising time is desired:
            H = 360 - math.deg (math.acos(cosH))
    
            H = H / 15
    
    
            --8. calculate local mean time of rising/setting
            T = H + RA - (0.06571 * t) - 6.622
            if T < 0 then

  5. #5
    Join Date
    Jan 1998
    Location
    Jupiter, FL
    Posts
    13,550

    Default

    Oh 4.0 :-) Yes,.. that one is getting older by now. Check your email :-)
    Ron
    No support through PM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •